Conversation
ghost
mentioned this pull request
Alistair-McGann-Tessella
left a comment
Alistair-McGann-Tessella
left a comment
There was a problem hiding this comment.
Needs minor changes and modbus support
| } | ||
|
|
||
| record(subArray, "$(DAQMX)CURR:DATA") { | ||
| field(DESC, "Reads a single raw current val") |
There was a problem hiding this comment.
This samples ~ 1 in 1000 data points (depending on data rate), which could be quite noisy. This is okay, but only if it's ballpark figure to be giving to the users on an OPI. If it's suspected that this could be used for other purposes then perhaps an average of the points would be better here.
| info(archive, "VAL") | ||
| } | ||
|
|
||
| record(calcout, "$(DAQMX)CURR:ACQUIRE:_TRIG") { |
There was a problem hiding this comment.
The method of this record is nontrivial, could you put a comment on this record explaining how and why it does what it does?
| field(DESC, "Reads an array of raw current data") | ||
|
|
||
| $(IFNOTRECSIM) field(SCAN,"I/O Intr") | ||
| $(IFNOTRECSIM) field(DTYP, "asynFloat64ArrayIn") |
There was a problem hiding this comment.
The dual DTYP fields here cause the DB unit checker to fail. This will need to be added as an exception to DBUnitChecker before this can be merged. Also applies to the voltage
1 participant
Description of work done
Ticket
#3404